github actions: added a rexstan job

.github/workflows/static-analysis.yml

@@ -143,3 +143,44 @@ jobs:
 
             -   name: Run phpstan analysis
                 run: vendor/bin/phpstan analyse --ansi
+
+    rexstan-analysis:
+        name: rexstan static code analysis
+        runs-on: ubuntu-latest
+        timeout-minutes: 30
+        permissions:
+            contents: write  # for Git to git apply
+
+        steps:
+            -   name: Checkout
+                uses: actions/checkout@v3
+
+            -   name: Setup PHP
+                uses: shivammathur/setup-php@v2
+                with:
+                    php-version: '8.2'
+                    extensions: gd, intl, imagick, pdo_mysql
+                    coverage: none # disable xdebug, pcov
+
+            -   name: Composer install
+                uses: ramsey/composer-install@v2
+                with:
+                    composer-options: --ansi --prefer-dist
+
+            -   name: Setup REDAXO
+                run: |
+                    sudo /etc/init.d/mysql start
+                    mysql -uroot -h127.0.0.1 -proot -e 'create database redaxo5;'
+                    php redaxo/bin/console setup:run -n --lang=de_de --db-host=127.0.0.1 --db-name=redaxo5 --db-password=root --db-createdb=no --db-setup=normal --admin-username=admin --admin-password=adminpassword --error-email=test@redaxo.invalid --ansi
+                    php redaxo/bin/console config:set --type boolean debug.enabled true
+                    php redaxo/bin/console config:set --type boolean debug.throw_always_exception true
+
+            -   name: Download & install rexstan
+                run: |
+                    php redaxo/bin/console install:download rexstan '^1'
+                    php redaxo/bin/console package:install rexstan
+                    php redaxo/bin/console package:activate rexstan
+                    php .tools/phpstan/rexstan.php
+
+            -   name: Run rexstan analysis
+                run: php redaxo/bin/console rexstan:analyze

.tools/phpstan/rexstan.php

@@ -0,0 +1,44 @@
+<?php
+/**
+ * boot redaxo and load packages
+ * necessary to use \rexstan\RexStanUserConfig::save()
+ */
+unset($REX);
+$REX['REDAXO'] = true;
+$REX['HTDOCS_PATH'] = './';
+$REX['BACKEND_FOLDER'] = 'redaxo';
+$REX['LOAD_PAGE'] = false;
+
+require './redaxo/src/core/boot.php';
+require './redaxo/src/core/packages.php';
+
+$extensions = [
+    '../../../../redaxo/src/addons/rexstan/config/rex-superglobals.neon',
+    '../../../../redaxo/src/addons/rexstan/vendor/phpstan/phpstan/conf/bleedingEdge.neon',
+    '../../../../redaxo/src/addons/rexstan/vendor/phpstan/phpstan-strict-rules/rules.neon',
+    '../../../../redaxo/src/addons/rexstan/vendor/phpstan/phpstan-deprecation-rules/rules.neon',
+    '../../../../redaxo/src/addons/rexstan/config/phpstan-phpunit.neon',
+    '../../../../redaxo/src/addons/rexstan/config/phpstan-dba.neon',
+    '../../../../redaxo/src/addons/rexstan/config/cognitive-complexity.neon',
+    '../../../../redaxo/src/addons/rexstan/config/code-complexity.neon',
+    '../../../../redaxo/src/addons/rexstan/config/dead-code.neon'
+];
+
+$paths = [
+    '../../../../redaxo/src/core',
+    '../../../../redaxo/src/addons/backup',
+    '../../../../redaxo/src/addons/be_style',
+    '../../../../redaxo/src/addons/cronjob',
+    '../../../../redaxo/src/addons/debug',
+    '../../../../redaxo/src/addons/install',
+    '../../../../redaxo/src/addons/media_manager',
+    '../../../../redaxo/src/addons/mediapool',
+    '../../../../redaxo/src/addons/metainfo',
+    '../../../../redaxo/src/addons/phpmailer',
+    '../../../../redaxo/src/addons/project',
+    '../../../../redaxo/src/addons/structure',
+    '../../../../redaxo/src/addons/users',
+];
+
+// creates a basic phpstan config file with all extensions
+\rexstan\RexStanUserConfig::save(6, $paths, $extensions, 80115);

redaxo/src/addons/backup/lib/backup.php

@@ -24,13 +24,13 @@
     /**
      * @param self::IMPORT_* $importType
      */
-    public static function isFilenameValid(int $importType, string $filename): bool
+    public static function isFilenameValid(int $importType, int $filename): bool
     {
         if (self::IMPORT_ARCHIVE === $importType) {
             return str_ends_with($filename, '.tar.gz');
         }
         if (self::IMPORT_DB === $importType) {
             return str_ends_with($filename, '.sql') || str_ends_with($filename, '.sql.gz');
         }
 
         throw new rex_exception('unexpected importType ' . $importType);
@@ -51,7 +51,7 @@
         foreach ($folder as $file) {
             $file = $file->getFilename();
             if (is_int($fileType)) {
                 if (self::isFilenameValid($fileType, $file)) {
                     $filtered[] = $file;
                 }
             } else {
@@ -87,7 +87,7 @@
             return ['state' => false, 'message' => $message];
         };
 
         if ('' == $filename || !self::isFilenameValid(self::IMPORT_DB, $filename)) {
             return $returnError(rex_i18n::msg('backup_no_import_file_chosen_or_wrong_version') . '<br>');
         }
 
@@ -216,7 +216,7 @@
         $return = [];
         $return['state'] = false;
 
         if ('' == $filename || !self::isFilenameValid(self::IMPORT_ARCHIVE, $filename)) {
             $return['message'] = rex_i18n::msg('backup_no_import_file_chosen') . '<br />';
             return $return;
         }