Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class Redaxo\Core\Util\VarDumper #6093

Merged
merged 3 commits into from
Apr 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .tools/psalm/baseline.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1556,11 +1556,6 @@
<code><![CDATA[$this->getParsedArg('suffix')]]></code>
</PossiblyNullOperand>
</file>
<file src="redaxo/src/core/lib/var_dumper.php">
<ArgumentTypeCoercion>
<code><![CDATA[$line]]></code>
</ArgumentTypeCoercion>
</file>
<file src="redaxo/src/core/lib/view.php">
<MixedArgument>
<code><![CDATA[$pageObj]]></code>
Expand Down Expand Up @@ -4671,6 +4666,11 @@
<code><![CDATA[$cast[2]]]></code>
</PossiblyUndefinedArrayOffset>
</file>
<file src="src/Util/VarDumper.php">
<ArgumentTypeCoercion>
<code><![CDATA[$line]]></code>
</ArgumentTypeCoercion>
</file>
<file src="src/Util/Version.php">
<FalsableReturnStatement>
<code><![CDATA[0 === $exitCode ? $version : null]]></code>
Expand Down
1 change: 1 addition & 0 deletions rector.php
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,7 @@
'rex_string' => Util\Str::class,
'rex_timer' => Util\Timer::class,
'rex_type' => Util\Type::class,
'rex_var_dumper' => Util\VarDumper::class,
'rex_factory_trait' => Base\FactoryTrait::class,
'rex_instance_list_pool_trait' => Base\InstanceListPoolTrait::class,
'rex_instance_pool_trait' => Base\InstancePoolTrait::class,
Expand Down
3 changes: 2 additions & 1 deletion redaxo/src/core/boot.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
use Redaxo\Core\Security\UserRole;
use Redaxo\Core\Translation\I18n;
use Redaxo\Core\Util\Timer;
use Redaxo\Core\Util\VarDumper;
use Symfony\Component\HttpFoundation\Request;

/**
Expand Down Expand Up @@ -132,7 +133,7 @@
}

rex_error_handler::register();
rex_var_dumper::register();
VarDumper::register();

// ----------------- REX PERMS

Expand Down
15 changes: 9 additions & 6 deletions redaxo/src/core/lib/var_dumper.php → src/Util/VarDumper.php
Original file line number Diff line number Diff line change
@@ -1,17 +1,20 @@
<?php

namespace Redaxo\Core\Util;

use Redaxo\Core\Core;
use Redaxo\Core\Filesystem\Path;
use Redaxo\Core\Security\BackendLogin;
use Redaxo\Core\Util\Editor;
use Symfony\Component\VarDumper\Cloner\VarCloner;
use Symfony\Component\VarDumper\Dumper\CliDumper;
use Symfony\Component\VarDumper\Dumper\ContextProvider\SourceContextProvider;
use Symfony\Component\VarDumper\Dumper\ContextualizedDumper;
use Symfony\Component\VarDumper\Dumper\HtmlDumper;
use Symfony\Component\VarDumper\VarDumper;
use Symfony\Component\VarDumper\VarDumper as BaseVarDumper;

use const PHP_SAPI;

abstract class rex_var_dumper
abstract class VarDumper
{
private static ?VarCloner $cloner = null;
private static ?ContextualizedDumper $dumper = null;
Expand All @@ -21,16 +24,16 @@ abstract class rex_var_dumper
*/
public static function register()
{
VarDumper::setHandler(static function ($var, ?string $label = null) {
BaseVarDumper::setHandler(static function ($var, ?string $label = null) {
if (Core::isDebugMode() || ($user = BackendLogin::createUser()) && $user->isAdmin()) {
VarDumper::setHandler(self::dump(...));
BaseVarDumper::setHandler(self::dump(...));
self::dump($var, $label);

return;
}

// register noop handler for non-admins (if not in debug mode)
VarDumper::setHandler(static function () {
BaseVarDumper::setHandler(static function () {
// noop
});
});
Expand Down
Loading