Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images aren't appearing when linked in Event description #96

Closed
declanslevin opened this issue Apr 5, 2018 · 7 comments
Closed

Images aren't appearing when linked in Event description #96

declanslevin opened this issue Apr 5, 2018 · 7 comments
Labels

Comments

@declanslevin
Copy link
Contributor

Tested with:
Physical Samsung Galaxy S8
Simulator iPhone X

When an image is hosted on Contentful and added to the Event description, it is not being loaded when the Event page is opened.
Images hosted externally are appearing as expected on Android, but not on a Simulated iPhone (still haven't succeeded at getting a build for iOS):

Android:
Android screen capture
(In this example the image at the top is from Google, the purple box with ? is where the Contentful image should appear)

iOS Simulator:
screenshot at apr 05 14-59-56

The example event is the one with the car-crash collection of emojis and symbols for a name, date is 20th April.

@robbiemccorkell
Copy link
Contributor

Out of interest were the images tested on an http or https url? iOS really hates loading assets that aren't https. Hopefully there's a way around it

@declanslevin
Copy link
Contributor Author

It was a http url, after changing it to https, it is loading the image on iOS

@robbiemccorkell
Copy link
Contributor

Cool ok, we'll have to try and figure out how to do http on iOS. I think it's just an xcode config or something.

@markholland
Copy link
Collaborator

You can add a domain whitelist to the info.plist https://cocoacasts.com/how-to-add-app-transport-security-exception-domains

@RGBboy
Copy link
Contributor

RGBboy commented Apr 20, 2018

Interestingly this works on my iOS simulator (iPhone 6 though). Has this been fixed inadvertently?

@declanslevin
Copy link
Contributor Author

declanslevin commented Apr 20, 2018

It isn't working on a physical iOS device (iPhone 6 / 7+).
Tried with a BrowserStack iPhone X and doesn't load there either.

I noticed if you click the "Read more" button it shows quite a large blank space, like it's trying to load everything, but it's just not appearing

@RGBboy
Copy link
Contributor

RGBboy commented May 11, 2018

Fixed in #267

@RGBboy RGBboy closed this as completed May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants