-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use official version of 7zip on Linux instead of unsupported p7zip #55
Comments
Hey, can you assign this to me? |
Hi @The-Debarghya, I've assigned you this issue. To make this change, you will likely have to change some Make sure to look at the contributing guide. Thanks for your interest in helping out! |
I'm struggling to figure out where to change the |
Variables using the name Instructions/code that installs
You can test the changes by running the following test: https://github.com/redballoonsecurity/ofrak/blob/master/ofrak_components/ofrak_components_test/test_p7zip_component.py. The test file might need to be updated as well. Hope this helps! |
p7zip variables can't be renamed to 7zip because python doesn't permit variable name starting with an integer, so should I name it like this: _7zip or maybe sevenZip? |
Either Regarding the filenames that sounds fine. |
…icComponentConfigs Merge master, Test new endpoint
See: https://news.ycombinator.com/item?id=31846317
Which files would be affected?
https://github.com/redballoonsecurity/ofrak/blob/master/ofrak_components/ofrak_components/p7zip.py
Does the proposed maintenance include non-doc string functional changes to the Python code?
Yes.
Are you interested in implementing it yourself?
No -- this is a great first issue!
The text was updated successfully, but these errors were encountered: