Bugfix/set id service #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbs-jacob
approved these changes
Jan 31, 2023
marczalik
pushed a commit
to marczalik/ofrak
that referenced
this pull request
Feb 14, 2023
* fix set_id_service so it actually works again * update changelog * update changelog with link --------- Co-authored-by: edward <edward@redballoonsecurity.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Fix long-broken
OFRAK.set_id_serviceLink to Related Issue(s)
set_id_serviceis supposed to be a convenient way to set the ID service (mainly to the sequential ID service, for testing), but has been broken for a long time. The problem is it sets thesyntholprovider for theIDServiceInterface, but the discovery of OFRAK classes happens later, which actually overwrite that provider with what it finds inofrak.Please describe the changes in your request.
Save the given ID service for later so that it won't be overwritten.
Anyone you think should look at this, specifically?
@rbs-jacob