Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add captions for ElfProgramHeader #223

Merged
merged 4 commits into from
Feb 14, 2023

Conversation

whyitfor
Copy link
Contributor

One sentence summary of this PR (This should go in the CHANGELOG!)
Add a caption to ElfProgramHeader.

Please describe the changes in your request.
This is a small quality-of-life improvement for the GUI:

image

Anyone you think should look at this, specifically?

Copy link
Member

@rbs-jacob rbs-jacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with the exception of one small comment!

ofrak_core/ofrak/core/elf/model.py Show resolved Hide resolved
@whyitfor whyitfor force-pushed the feature/elf_program_header_captions branch from 66c6286 to b1a48cb Compare February 14, 2023 04:03
@rbs-jacob rbs-jacob merged commit 6b298a5 into master Feb 14, 2023
marczalik pushed a commit to marczalik/ofrak that referenced this pull request Feb 14, 2023
* Add captions for ElfProgramHeader

* Fix duplicate Changed section

* Adding link to Elf Program Header type enum source.
@whyitfor whyitfor deleted the feature/elf_program_header_captions branch March 6, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants