-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better view analysis #264
Better view analysis #264
Conversation
…for analyzers that output all of those attrs
I'm a little confused about whether this reliably solves the problem based on this last bullet:
This makes it sound like there is still a risk of deadlock in certain circumstances? |
That's correct. The true solution to the root cause would be pretty complicated. The approach I have in mind is to flesh out the job context to include a "stack" of the components or at least analyzers being run, and raise an error when the same analyzer appears twice in the stack. However that would take me a couple days at least to do, this took me an hour or so. And besides this does solve a real problem: The wrong analyzer was being chosen in a test that was deadlocking. The job service was choosing the |
Thanks for the clarification! |
…putting each attribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two very small changes, and this should be good to go!
One sentence summary of this PR (This should go in the CHANGELOG!)
Choose Analyzer components which output the entirety of a view, rather than piece by piece, which would choose the wrong Analyzer sometimes.
Link to Related Issue(s)
ResourceViews are composed of multiple attributes types, and when running something like
view_as
OFRAK would previously make a request for each of those attributes types. With limited visibility into what the user actually wants, the job service would sometimes end up choosing Analyzers which do output one or more of the requested attributes but actually require the analysis of the other attributes, resulting in a deadlock.Please describe the changes in your request.
view_as
uses this)Anyone you think should look at this, specifically?
@rbs-jacob