Fix UF2 file identification so that it works #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a Magic Mime identifier for UF2 files - Deletes custom Uf2FileIdentifier which was not working - Updates UF2 tests with a test to assert that identification works - Update UF2 unpack test to remove adding Uf2File tag (this was making the test pass even though the identifier wasn't working)
|
Good catch and thanks for the neat fix! |
sjossi
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
UF2 file identification was not working. This PR fixes this, and updates the tests to specifically test that identifcation works.
Please describe the changes in your request.
Anyone you think should look at this, specifically?
@sjossi