Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies for tools which were missing them #299

Merged

Conversation

EdwardLarson
Copy link
Collaborator

@EdwardLarson EdwardLarson commented May 1, 2023

One sentence summary of this PR (This should go in the CHANGELOG!)
Mark dependencies on libmagic and strings utility.

Link to Related Issue(s)
These are tools which OFRAK depends on. On some platforms, like Mac, they are not necessarily installed. They should have been explicitly marked as dependencies so the ofrak deps command can find and install them when necessary.

Please describe the changes in your request.

Anyone you think should look at this, specifically?

Copy link
Contributor

@whyitfor whyitfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! See one comment about raising a ComponentMissingDependencyError.

@whyitfor
Copy link
Contributor

@EdwardLarson, can you add a "fixed" changelog to OFRAK core for the Magic issue? Otherwise I think this looks good!

@whyitfor whyitfor merged commit c1bd250 into redballoonsecurity:master Jun 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants