-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependencies for tools which were missing them #299
Merged
whyitfor
merged 7 commits into
redballoonsecurity:master
from
EdwardLarson:maintenance/missing_tool_deps
Jun 2, 2023
Merged
Add dependencies for tools which were missing them #299
whyitfor
merged 7 commits into
redballoonsecurity:master
from
EdwardLarson:maintenance/missing_tool_deps
Jun 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbs-jacob
reviewed
May 1, 2023
rbs-jacob
approved these changes
May 1, 2023
whyitfor
reviewed
May 1, 2023
whyitfor
reviewed
May 1, 2023
whyitfor
reviewed
May 15, 2023
whyitfor
reviewed
May 15, 2023
whyitfor
reviewed
May 23, 2023
whyitfor
reviewed
May 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! See one comment about raising a ComponentMissingDependencyError
.
whyitfor
approved these changes
May 24, 2023
@EdwardLarson, can you add a "fixed" changelog to OFRAK core for the Magic issue? Otherwise I think this looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Mark dependencies on libmagic and
strings
utility.Link to Related Issue(s)
These are tools which OFRAK depends on. On some platforms, like Mac, they are not necessarily installed. They should have been explicitly marked as dependencies so the
ofrak deps
command can find and install them when necessary.Please describe the changes in your request.
Anyone you think should look at this, specifically?