Fix AARCH64 Keystone Vector Instructions bug #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… poorly with vector instructions
whyitfor
requested changes
May 30, 2023
There was a problem hiding this comment.
@rbs-alexr, can you add a tests case that fails before this change is made?
…r vector instructions, added unit tests
|
To provide some context to the most recent commits. The erroneous behavior we were observing was not due to keystone, it was due to our own _asm_fixups function in disassembler_service_capstone. We had regex to convert constants to their hex values, which breaks for vector instructions. The new code skips this conversion if the mnemonic is from a list of known AARCH64 vector instructions |
disassemblers/ofrak_capstone/ofrak_capstone/disassembler_service_capstone.py
Outdated
Show resolved
Hide resolved
…mbler_service_capstone.py Co-authored-by: Edward Larson <wasabiofip@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
When capstone disassembles the bytes for the following instruction "movi v0.2d #0" it represents it as "movi v0.0x2d #0" which causes keystone to throw an "Unknown Operand" error.
Link to Related Issue(s)
N/A
Please describe the changes in your request.
I added some processing to the assembler_service_keystone to work around this capstone bug
Anyone you think should look at this, specifically?
@whyitfor