Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/stream resource from frontend #324

Merged
merged 46 commits into from Jun 19, 2023
Merged

Feature/stream resource from frontend #324

merged 46 commits into from Jun 19, 2023

Conversation

dannyp303
Copy link
Collaborator

One sentence summary of this PR (This should go in the CHANGELOG!)
Upload files in chunks to handle files larger than 2G

Link to Related Issue(s)

Please describe the changes in your request.

Anyone you think should look at this, specifically?

Dan Pesce added 23 commits May 24, 2023 13:37
Fix existing highliting and add orange highlight for previously modified
d6c7321
add range into get_data request and test
e8606b5
lint
beaf8bd
replace all data.byteLength with dataLenPromise
711fbb7
Lazily grabs data but resets the address to 0
cbb9908
Append new data to existing data
6541625
Use window for data, rapid requests at edges
a5d96e1
lint
d5718d3
Remove dataPromise from App.svelte
cf7d3cd
20k data requests feels good
8795db7
Merge branch 'master' of github.com:dannyp303/ofrak into feature/larg…
97751a1 
…e-file-speedup
Some changes from a different PR made it in
fda107f
Missed one
6c358ae
Fix failing test
c280477
simple changes per PR
7b81ad6
lint
037e4d1
Call get_data_length in JumpToOffset
f2394ef
Add window padding
8935d97
Undo JumpToOffset change to push to seperate PR
63d4539
Chunk data to upload large files
e9bc52a
remove data from dict after load
e0541d1
add addr to query to avoid out of order errors
d73155c
Merge branch 'master' into feature/stream-resource-from-frontend
d9bee61
@dannyp303 dannyp303 requested a review from rbs-jacob June 7, 2023 17:38
EdwardLarson
EdwardLarson requested changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@EdwardLarson EdwardLarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge master into this to make sure the changelog is updated properly (i.e. this changelog entry goes into Unreleased section, not 3.1.0 section, as automatic merge will likely do)

rbs-jacob
rbs-jacob requested changes Jun 14, 2023
View reviewed changes
ofrak_core/ofrak/gui/server.py Outdated Show resolved Hide resolved
ofrak_core/test_ofrak/unit/test_ofrak_server.py Outdated Show resolved Hide resolved
frontend/src/StartView.svelte Outdated Show resolved Hide resolved
frontend/src/StartView.svelte Outdated Show resolved Hide resolved
ofrak_core/ofrak/gui/server.py Outdated Show resolved Hide resolved
@dannyp303 dannyp303 requested a review from rbs-jacob June 14, 2023 20:38
rbs-jacob
rbs-jacob requested changes Jun 15, 2023
View reviewed changes
ofrak_core/ofrak/gui/server.py Outdated Show resolved Hide resolved
ofrak_core/ofrak/gui/server.py Outdated Show resolved Hide resolved
ofrak_core/ofrak/gui/server.py Outdated Show resolved Hide resolved
ofrak_core/ofrak/gui/server.py Outdated Show resolved Hide resolved
@dannyp303 dannyp303 requested a review from rbs-jacob June 15, 2023 20:07
rbs-jacob
rbs-jacob approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@rbs-jacob rbs-jacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@EdwardLarson and @whyitfor may have comments before we merge

@dannyp303 dannyp303 requested a review from rbs-jacob June 19, 2023 18:45
dannyp303 and others added 2 commits June 19, 2023 17:21
@dannyp303 @rbs-jacob
Update ofrak_core/test_ofrak/unit/test_ofrak_server.py
afea4bf 
Co-authored-by: Jacob Strieb <99368685+rbs-jacob@users.noreply.github.com>
Make file bigger
60eb2f0
@rbs-jacob rbs-jacob merged commit 9077efc into redballoonsecurity:master Jun 19, 2023
5 checks passed
@EdwardLarson EdwardLarson mentioned this pull request Aug 10, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbs-jacob rbs-jacob rbs-jacob approved these changes

@EdwardLarson EdwardLarson EdwardLarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dannyp303 @EdwardLarson @rbs-jacob