ofrak_patch_maker no longer looks for toolchain.conf in "/etc". #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
EdwardLarson
approved these changes
Jun 29, 2023
whyitfor
force-pushed
the
maintenance/etc_toolchain
branch
from
4525fab
to
de1bd65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
ofrak_patch_maker does not look for toolchain.conf in
/etc.Link to Related Issue(s)
This issue partially addresses problems raised in #340.
Please describe the changes in your request.
ofrak_patch_makerinitially assumed that the toolchain.conf was in/etc.When the package was added to PyPI, the
toolchain.confstarted to get bundled with the package itself.Given this, there is no need to search for
toolchain.conf. This PR removes this logic entirely:toolchain.confis only searched for in theofrak_patch_makerpackage.This change makes local installs easier, as copying the toolchain config to
/etcoften required root privileges.Anyone you think should look at this, specifically?
FYI @ANogin, @Jepson2k.