Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Debugger modes #1

Merged
merged 11 commits into from Sep 11, 2021
Merged

Conversation

jakubboucek
Copy link
Member

@jakubboucek jakubboucek commented Oct 21, 2020

Allow to select methods for Debug mode detection.

Changes:

  • Allowed methods: IP, Environment, Cookie, Enabler and their combinations: Full mode (all methods) and Simple mode (without Enabler).
  • Temp directory is no more required to simple mode without Enabler.
  • IP mode is no more hardcoded to localhost, not allow to specify custom IP addresses.

Example:

Detect Debug mode only by Environment and Enabler – methods IP and Cookie does not be used.

$debugMode = Detector::detect(Detector::MODE_ENABLER | Detector::MODE_ENV, $tempDir); //bool

Or disable IP method:

$debugMode = Detector::detect(Detector::MODE_FULL & ~Detector::MODE_IP, $tempDir); //bool

@jakubboucek jakubboucek self-assigned this Oct 21, 2020
@jakubboucek jakubboucek force-pushed the feature/filter-detect-method branch 2 times, most recently from fa5c463 to acc5725 Compare October 27, 2020 14:12
@jakubboucek jakubboucek changed the base branch from master to v3.0 September 5, 2021 21:46
@jakubboucek jakubboucek marked this pull request as draft September 5, 2021 21:55
@jakubboucek jakubboucek changed the title Add experiment: bulk detect method filter Refactoring: Debugger modes Sep 5, 2021
@jakubboucek jakubboucek added this to the v3.0 milestone Sep 5, 2021
@jakubboucek jakubboucek marked this pull request as ready for review September 11, 2021 09:45
@jakubboucek jakubboucek merged commit 4cc59cf into v3.0 Sep 11, 2021
@jakubboucek jakubboucek deleted the feature/filter-detect-method branch September 11, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant