This repository has been archived by the owner on May 13, 2021. It is now read-only.
fall back to sendmail if smtp server is disabled #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VoyTechnology
suggested changes
Mar 7, 2017
| @@ -0,0 +1,11 @@ | |||
| const nodemailer = require('nodemailer'); | |||
|
|
|||
| const sendmail = { | |||
There was a problem hiding this comment.
I would prefer if it was part of _config.yml as emailFallback or something like that.
|
I Considered that but I didn't see that as a fallback but as an alternative |
|
But it is a fallback. It would be an alternative if you had an option to use one or another. But here the sendmail is only used if SMTP fails. |
|
Why is there yarn update's in this? Seem's totally unrelated to the change |
|
I had some weird dependency issue I solved with an upgrade. Can remove it if yiu want |
|
we dont want it as an alternative, we only want it for when smtp fails |
|
What is the point of reviews if you ignore them. |
|
i didnt ignore it had a green button |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.