Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The glTF model of T-Rex is not animated #448

Closed
cx20 opened this issue Jan 16, 2019 · 6 comments
Closed

The glTF model of T-Rex is not animated #448

cx20 opened this issue Jan 16, 2019 · 6 comments
Assignees
@redcamel
Labels
bug Something isn't working

Comments

@cx20
Copy link

cx20 commented Jan 16, 2019

I tried to display the T-Rex model. However, the model is not animated.

RedGL + T-Rex model result:

RedGL.js:11969 
Uncaught TypeError: Cannot set property 'geometry' of undefined
    at RedGL.js:11969
    at Array.forEach (<anonymous>)
    at parseSkin (RedGL.js:11965)
    at RedGL.js:12036

three.js + T-Rex model result
image
@redcamel redcamel self-assigned this Jan 16, 2019
@redcamel redcamel added the bug Something isn't working label Jan 16, 2019
@redcamel
Copy link
Owner

@cx20 This problem is the same as the problem of #441.
I fixed this problem more powerfully.

redcamel added a commit that referenced this issue Jan 16, 2019
@redcamel
#448
ad1a176
@redcamel redcamel mentioned this issue Jan 16, 2019
Merged
redcamel added a commit that referenced this issue Jan 16, 2019
@redcamel
Merge pull request #449 from redcamel/dev
379ec43 
#448
@redcamel redcamel mentioned this issue Jan 16, 2019
Merged
redcamel added a commit that referenced this issue Jan 16, 2019
@redcamel
Merge pull request #450 from redcamel/dev
0279fab 
#448
@redcamel redcamel mentioned this issue Jan 16, 2019
Merged
@redcamel
Copy link
Owner

@cx20 test here.

@cx20
Copy link
Author

cx20 commented Jan 16, 2019

@redcamel Thank you for fixing. But, I think that the way the tail is swung is incorrect.
image

@redcamel
Copy link
Owner

redcamel commented Jan 17, 2019 •
edited
Loading

@cx20
This is a limitation on the maximum number of joints.
currently branching by mobile, browser state. will be fix to use more joints soon.

redcamel added a commit that referenced this issue Jan 17, 2019
@redcamel
#448
2564e88
@redcamel redcamel mentioned this issue Jan 17, 2019
Merged
redcamel added a commit that referenced this issue Jan 17, 2019
@redcamel
Merge pull request #452 from redcamel/dev
1f90e5f 
#448
@redcamel
Copy link
Owner

@cx20 fixed it. test here.
current joint limitation.
desktop : 256
mobile : 64
ie11 : 50
iphone, ipad : 8

@cx20
Copy link
Author

cx20 commented Jan 17, 2019

I confirmed that I can animate correctly with the latest version of RedGL.
RedGL + T-Rex model result:
t-rex-20180117_002

@cx20 cx20 closed this as completed Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redcamel redcamel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@redcamel @cx20