Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent PowerShell Executor.Command Properties #322

Closed
ghost opened this issue Sep 2, 2018 · 1 comment
Closed

Inconsistent PowerShell Executor.Command Properties #322

ghost opened this issue Sep 2, 2018 · 1 comment

Comments

@ghost
Copy link

ghost commented Sep 2, 2018

Sometimes we use powershell, powershell.exe and sometimes nothing.

We need to review each powershell test and choose a consistent pattern.

Compare 1086, 1050 and 1098 for examples.

@ghost
Copy link
Author

ghost commented Sep 3, 2018

After testing, I think we remove the word powershell or powershell.exe from the test itself since this is implied by the executor.command property and makes it easier to write the test case

MHaggis pushed a commit that referenced this issue Sep 5, 2018
Fixed per issue #322
@MHaggis MHaggis closed this as completed Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant