Fix critical error in readme.md #8
Conversation
|
This is a serious error that will leave a lot of users infuriated. I vote - pull this fix as soon as possible! |
|
Please fix this issue. Master branch is unusable in its current state. |
|
Pls fix Thx |
|
Please add unit tests for this fix. |
|
Since the author is gonna be confused as hell I thought I'd add the link where all the reactions are coming from. |
|
Thank god someone found this failure - how could QA have missed it? |
|
Repo is unusable. Please accept this MR |
|
+1 |
|
Google wants to know your location |
|
Please merge ASAP. |
|
+1 |
|
We’ve been using this in production for months and our legal team just brought this to my (the very, very important CTO) attention. Please merge this PR or I’ll be forced to report you to the GitHub grammar police. |
|
LGTM |
|
|
|
+1 |
|
Hey guys, I built a JavaScript library as a solution to this bug. It's called Your.js |
|
This bug avoid to read the file completely, merge ASAP!! |
|
Which font is that? |
|
Also might want to consider: |
|
Critical issue |
| @@ -93,7 +93,7 @@ Other popular BTC average modules require incredible amount of bandwidth at regu | |||
|
|
|||
| This module **does not include exchange API's that do not have web sockets**. Why? Theres a billion other modules that do something similar, and perhaps this is a wake up call to any exchange that does not offer rhobust websocket support. | |||
There was a problem hiding this comment.
While we're at it, can we change "API's" to "APIs"? Thanks.
| @@ -93,7 +93,7 @@ Other popular BTC average modules require incredible amount of bandwidth at regu | |||
|
|
|||
| This module **does not include exchange API's that do not have web sockets**. Why? Theres a billion other modules that do something similar, and perhaps this is a wake up call to any exchange that does not offer rhobust websocket support. | |||
|
|
|||
| Many developers would rather not be bothered reading through additional API documentation which, in many cases, is incomplete, hard to follow and usually lacking node.js examples. I did it for you! In node. Your welcome. | |||
| Many developers would rather not be bothered reading through additional API documentation which, in many cases, is incomplete, hard to follow and usually lacking node.js examples. I did it for you! In node. You're welcome. | |||
|
|
|||
| ### Why Should I use websockets? | |||
|
LGTM 👍 |
|
LGTM. Some automatic tests should be made before making to the master branch though. |
|
Is there a workaround for this for the time-being ? |
|
This is a showstopper for my organisation. My boss is really riding me hard on this one, I assured him that crypto-socket was a stable library. |
|
In all seriousness I was actually fired for critical errors such as these long long ago while working in the (Silicon) Valley; but that was not a programming job. This is merely a hobby for me, I appreciate the attention to detail, language is something I struggle with daily. I have since banished myself from civilization as I am essentially unemployable in every industry. |
|
It was totally unusable before, thank god it got fixed, good job @stackola. |
|
No one's said it yet ...
|
|
Attention grammar police; there is a new PR that desperately needs your attention, I feel if we all work together we can make these new changes a reality. #9 ; I am very suspicious of the changes and require your assistance to validate them. I am somewhat opposed to the use of the oxford comma in technical documentation but I am open to the discussion so long as there are sufficient reviewers. While you're here please star the repo; perhaps it may reach trending status so that we may garner additional attention for this fastidious work. |
No description provided.