Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature added action tests #110

Merged
merged 56 commits into from
Mar 16, 2019
Merged

Feature added action tests #110

merged 56 commits into from
Mar 16, 2019

Conversation

maZahaca
Copy link
Member

@maZahaca maZahaca commented Mar 1, 2019

Requires:

  • all environments should have method goto(url): Promise, which will navigate current page to new url and wait for required scripts for loading on the page.
  • all environment should implement callbacks in browser events
  • removed errbacks compatibility

- added finish method to do a signal to environment that nothing more will be parsed and it should be shut down
- fixed coverage issue

:goose:
- Running tests one-by-one (every test runs in it's own Chrome)

:goose:
- ActionProvideRules - added tests

:goose:
- fixed ActionOpen to have proper opening a new page with loading extra libraries

:goose:
- updated environments for using callbacks

:goose:
- removed methods set, get, unset from Actions

:goose:
- added unified waitFor property which can contain all waiting actions

:goose:
@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #110 into master will increase coverage by 57.34%.
The diff coverage is 81.41%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #110       +/-   ##
===========================================
+ Coverage      19%   76.34%   +57.34%     
===========================================
  Files          54       54               
  Lines         800      782       -18     
  Branches      168      167        -1     
===========================================
+ Hits          152      597      +445     
+ Misses        515      159      -356     
+ Partials      133       26      -107
Impacted Files Coverage Δ
lib/actions/actionsFactory.js 50% <ø> (+50%) ⬆️
lib/actions/ActionWaitForPattern.js 100% <100%> (+100%) ⬆️
lib/actions/ActionWaitForElement.js 100% <100%> (ø)
lib/actions/ActionUrl.js 100% <100%> (+100%) ⬆️
lib/actions/ActionFocus.js 100% <100%> (+100%) ⬆️
lib/actions/ActionOpen.js 100% <100%> (+100%) ⬆️
lib/actions/ActionClick.js 100% <100%> (+100%) ⬆️
lib/actions/ActionWaitForPage.js 100% <100%> (+100%) ⬆️
lib/actions/ActionExist.js 100% <100%> (+100%) ⬆️
lib/actions/ActionWait.js 100% <100%> (+100%) ⬆️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f28670d...1ffe8de. Read the comment docs.

@jifeon
Copy link
Contributor

jifeon commented Mar 5, 2019

🐗

@maZahaca maZahaca merged commit d08d7ae into master Mar 16, 2019
@maZahaca maZahaca deleted the feature-added-action-tests branch March 16, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants