New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test for using external services #11

Closed

maZahaca opened this issue Sep 29, 2015 · 3 comments

Member

maZahaca commented Sep 29, 2015

Do NOT use external services in test, need to mock them to add more stability to tests

Member Author

maZahaca commented Nov 10, 2015

One more provider is still using external service.

@remedge Could you look on this? And do almost the same as you did before + a bit refactoring of CbrProvider

Contributor

remedge commented Nov 10, 2015

@maZahaca i'll do my best)

Contributor

remedge commented Nov 17, 2015

Here is the PR - #14

maZahaca closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment