Improve cbr provider #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
remedge
commented
Nov 17, 2015
remedge
commented
- add loader classes;
- add tests.
- add loader classes; - add tests.
| */ | ||
| public function parse($string) | ||
| { | ||
| return new \SimpleXMLElement($string); |
There was a problem hiding this comment.
What is the purpose to move it to external class?
You can reach the same effect just having SOAPLoader and mocking of it.
There was a problem hiding this comment.
You are quite right, it is unnecessary class.
- remove XMLParser class; - remove extra underscores; - refactoring tests.
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.