Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test class had duplicate name #44

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

mattmassicotte
Copy link
Contributor

Was just playing around with some tests, and noticed that the test target couldn't build because two classes had the same name. I used the file name as a clue for what to use.

The contents of the tests are extremely similar but not identical, and I think these really are testing different things. Hope this looks ok, but happy to defer to you!

Copy link
Owner

@reddavis reddavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@reddavis reddavis merged commit 0697018 into reddavis:main Nov 11, 2022
@mattmassicotte mattmassicotte deleted the fix/test-name branch November 11, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants