This repository has been archived by the owner on Dec 9, 2017. It is now read-only.
Modify Namespace method missing, only use caller when error
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the namespace's method missing to only call the `caller` when an exception occurs. This is more efficient and speeds up all access to reading/writing namespace options. This is an internal change so no tests had to be modified. There are already tests that ensure the behavior for raising no method errors and setting the backtrace to the caller is still working. Closes #82
|
@jcredding good by me - nice catch. |
jcredding
added a commit
that referenced
this pull request
Nov 6, 2013
Modify `Namespace` method missing, only use `caller` when error
jcredding
added a commit
that referenced
this pull request
Nov 6, 2013
* Namespace method missing, don't get `caller` unless needed (#83) /cc @kellyredding
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the namespace's method missing to only call the
callerwhen an exception occurs. This is more efficient andspeeds up all access to reading/writing namespace options. This
is an internal change so no tests had to be modified. There are
already tests that ensure the behavior for raising no method
errors and setting the backtrace to the caller is still working.
Closes #82