Skip to content

Commit

Permalink
Hotfix: Fix closing dropdowns
Browse files Browse the repository at this point in the history
This fixes a bug with the event binding for the close elem. The
function name was updated to use our private function name
scheme but the event binding was still using the old name. This
was causing errors when clicking the close button on a dropdown.
  • Loading branch information
jcredding committed Oct 24, 2017
1 parent 46ca5f9 commit ae43d45
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion assets/js/romo/dropdown.js
Expand Up @@ -284,7 +284,7 @@ RomoDropdown.prototype._bindBody = function() {

this.closeElem = Romo.find(this.popupElem, '[data-romo-dropdown-close="true"]')[0];
if (this.closeElem !== undefined) {
Romo.on(this.closeElem, 'click', Romo.proxy(this.onPopupClose, this));
Romo.on(this.closeElem, 'click', Romo.proxy(this._onPopupClose, this));
}

Romo.setStyle(this.contentElem, 'min-height', Romo.data(this.elem, 'romo-dropdown-min-height'));
Expand Down

1 comment on commit ae43d45

@jcredding
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.