Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the script command #58

Closed
spladug opened this issue Nov 4, 2016 · 6 comments
Closed

Improve the script command #58

spladug opened this issue Nov 4, 2016 · 6 comments

Comments

@spladug
Copy link
Contributor

spladug commented Nov 4, 2016

@spladug
Copy link
Contributor Author

spladug commented Dec 6, 2016

How can we make health checks a thing for daemons?

@bradengroom
Copy link
Member

Allow the script to parse arguments itself

+1 on this part. We've had to break out of baseplate-script a couple of times now just so we can parse arguments.

@bradengroom
Copy link
Member

What would passing arguments to the underlying script look like? I've seen this syntax in a couple of places:
vagrant ssh -- -R 9090:localhost:9090

Maybe a similar syntax would make sense?
baseplate-script example.ini some.module:run -- --my-option=foo

@AngryEgret
Copy link

parser.add_argument('args', nargs=argparse.REMAINDER) might be enough.

@spladug
Copy link
Contributor Author

spladug commented Aug 9, 2019

This was fixed by @bradengroom in d79ddda

@spladug spladug closed this as completed Aug 9, 2019
@spladug
Copy link
Contributor Author

spladug commented Aug 9, 2019

Make it possible to run scripts directly by filename rather than doing global module lookup.

and this should be possible with 78d27b8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants