Voting and commenting for posts and comments #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,6 +2,8 @@ import RedditModel from './RedditModel'; | |||
| import Record from '../apiBase/Record'; | |||
| import { COMMENT, COMMENT_LOAD_MORE } from './thingTypes'; | |||
|
|
|||
| import votable from './mixins/votable'; | |||
There was a problem hiding this comment.
How do we feel about this style of adding functionality? We could also consider decorators as a cleaner syntax.
There was a problem hiding this comment.
I think this is fine. I'm hesitant to add decorators to node-build yet as the spec is in flux (more info). From what I've read the new spec isn't completely backwards-compatible, and adding the babel-plugin for the 'legacy' syntax can interact with the static properties plugin in obscure, error'ing, ways. It might be better now so maybe thats worth re-considering
ajacksified
changed the title
| export function _vote (apiOptions, direction) { | ||
| const oldModel = this; | ||
|
|
||
| const stub = this.stub('likes', direction, async (resolve, reject) => { |
|
馃悷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憮 @schwers