This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Minor spelling fixes & refactoring #1207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1236,8 +1235,7 @@ def add_props(cls, user, wrapped): | |||
| item.subreddit.contest_mode_upvotes_only and | |||
| not item.score_hidden): | |||
| item.score = item._ups | |||
| item.voting_score = [ | |||
| item.score - 1, item.score, item.score + 1] | |||
| item.voting_score = [(item.score + x - 1) for x in range(3)] | |||
There was a problem hiding this comment.
This change was made to match the way voting_score is defined in builder.py and subreddit.py.
- Reorganized boolean logic - Changed item.voting_score definition to match the way it is defined in other parts of the codebase
|
Resolved merge conflict and rebased on top of master. |
|
Thanks for the pull request, but we're not going to accept this. We tend not to accept cosmetic-only changes and prefer to do cleanup like this when we need to modify the nearby code. Sorry! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I felt like some of the boolean logic in
link.pywas a little cluttered so I tried to reorganize it a bit; also, I caught a couple of minor spelling errors in the process.