This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Fix /r/all-<sub>/comments #1510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Pokechu22 pointed out to check /r/all-<sub>/comments and /me/f/all/comments. It turns out that even without /comments being able to be sortable, they are broken due to the fact that they had not separate method to filter out comments. This commit resolves the above issue.
|
Sorry, but this repository is no longer accepting pull requests. https://www.reddit.com/r/changelog/comments/6xfyfg/an_update_on_the_state_of_the_redditreddit_and/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@umbrae asked me to separate this from #1440 a long time ago, but I'm a horrible human being that managed to forget and I only now remembered since I was trying to figure out the mystery behind #1496 (and get green checkmarks on my branches)