Skip to content
This repository has been archived by the owner on Sep 18, 2018. It is now read-only.

Commit

Permalink
Fix Ctrl-arrow cursor movement in submit bar textbox by halting bubbl…
Browse files Browse the repository at this point in the history
…ing of the keypress event.
  • Loading branch information
chromakode committed Feb 1, 2009
1 parent eeff2c8 commit 60eb896
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions NEWS
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
== Version 1.3.2 ==
* Fix namespace pollution.
* Fix Ctrl-arrow cursor movement in submit bar textbox.
* Fix spurious bar triggering on subreddit listings and some profile page links.
* Fix minor bug when canceling adding a site.
* Fix minor internal cleanup bug in the site dropdown.
Expand Down
6 changes: 5 additions & 1 deletion content/socialiteBar.xml
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,11 @@
<xul:label anonid="labelSiteSelector" value="&loadedSiteSelector.label;"/>
<xul:hbox anonid="loadedSiteSelector"/>
<xul:separator width="0px" height="18px" orient="vertical" class="socialite-separator"/>
<xul:hbox anonid="siteSubmitUIContainer" flex="1" align="center">
<!--
Firefox's tabbrowser has a handler that catches Ctrl-arrow keys and cancels the default event, interfering with word-by-word keyboard navigation in textboxes.
We'll prevent the keypress event from bubbling outside the container to this problematic handler, so individual site submit UIs don't have to worry about this.
-->
<xul:hbox anonid="siteSubmitUIContainer" flex="1" align="center" onkeypress="event.stopPropagation();">
<children/>
</xul:hbox>
</xul:hbox>
Expand Down

0 comments on commit 60eb896

Please sign in to comment.