Merge pull request #32 from aickin/common-chunk

Move common code out into a common chunk so that it can be separately cached
redfin · Feb 23, 2016 · e30947a · e30947a
2 parents c69b326 + 8c98fbb
commit e30947a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/packages/react-server-cli/src/compileClient.js b/packages/react-server-cli/src/compileClient.js
@@ -84,6 +84,10 @@ const packageCodeForBrowser = (entrypoints, outputDir, outputUrl, hot, minify) =
 		},
 		plugins: [
 			new ExtractTextPlugin("[name].css"),
+			new webpack.optimize.CommonsChunkPlugin({
+				name:"common",
+				filename: "common.js",
+			}),
 		],
 	};
 

diff --git a/packages/react-server-cli/src/coreJsMiddleware.js b/packages/react-server-cli/src/coreJsMiddleware.js
@@ -4,6 +4,7 @@ export default (pathToStatic) => {
 			const routeName = this.getRequest().getRouteName();
 			const baseUrl = pathToStatic || "/";
 			return [
+				`${baseUrl}common.js`,
 				`${baseUrl}${routeName}.bundle.js`,
 				{
 					type: "text/javascript",