Add .sass support #579
Add .sass support #579
Conversation
This adds real .sass support, not just the .scss support. We don't need to add `indentedSyntax` to the sass loader parameters since the sass loader doesn't require it anymore (webpack-contrib/sass-loader#196)
|
|
|
lgtm 👍 Thanks @alex88 |
|
Nice, thanks @alex88! If you're feeling ambitious you could also add a |
|
Ok let me do that right now, just a quick question, how you test those pages? create a project using the local linked version of the cli? |
|
Oh nvm, RTFM to me :D |
|
Heh, yep some basic instructions in the README.
^ That's actually covered by the If you run into any trouble just ask here or on slack! |
|
Already tried to join slack before |
|
Whoa, that's not good! @davidalber - Looks like slackin's rejecting people! |
|
Damn, so strict :) Maybe contact them directly, or have an IRC channel too :) |
|
Yeah, I reached out via their help form. :fingers_crossed: No need to squash. Your commits represent discrete logical changes. Thanks for improving React Server! |
|
@gigabo is there a way to use the master version in a project? I've seen that npm doesn't support using packages directly from a git subfolder, you guys ever found a solution? |
|
@alex88 We've just been trying to publish frequently so the latest features/fixes are available. I'll publish |
|
Awesome! 🎉 I just tried to checkout locally and seems the sub-dependencies can't be loaded.. |
|
You bet! Here you go: https://github.com/redfin/react-server/releases/tag/v0.4.4 |
This adds real .sass support, not just the .scss support.
We don't need to add
indentedSyntaxto the sass loader parameters since the sass loaderdoesn't require it anymore (webpack-contrib/sass-loader#196)