Make the indentedSyntax option a bit smarter.
#196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of forcing loader config to set `sass?indentedSyntax` to compile whitespace significant Sass files, automatically set it if necessary (if the current file is a SASS file). This should make loader config a bit easier, because now you won’t need to have separate loaders for SCSS And SASS. Additionally this has the side benefit of enabling SCSS <-> SASS interop in some advanced cases. Without this, it wasn’t possible for my [sprockets-directive-loader](https://github.com/timmfin/sprockets-direct ive-loader) project to work when a SASS file `//= require`ed a SCSS file. That’s because you would have had to set `indentedSyntax` on the loader, and that would have been “passed-on” (via `css?importLoaders=1`) to the SCSS file, causing its compile to fail. So with this change, this will now work for a mix of SCSS and SASS files: ``` { test: /\.(scss|sass)$/, loader: ExtractTextPlugin.extract("style", "css?sourceMap&importLoaders=2!sprockets-directive!sass?sourceMap") } ```
lutzk
added a commit
to lutzk/sass-loader
that referenced
this pull request
Dec 17, 2015
jhnns
added a commit
that referenced
this pull request
Mar 3, 2016
…-option Make the `indentedSyntax` option a bit smarter.
|
Seems reasonable, thx 👍 |
|
Great change, thanks very much! 👍 |
|
💃💃, thanks for merging! |
jhnns
added a commit
that referenced
this pull request
Mar 12, 2016
Thus we are testing #196 implicitly
|
Shipped with |
|
This is very cool. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of requiring loader config to set
sass?indentedSyntaxto compile whitespace significant Sass files, this change will automatically set it for you if necessary (when the current file is a SASS file).This should make loader config a bit easier, because now you won’t need to have separate loaders for SCSS And SASS. For example:
Additionally this has the side benefit of enabling SCSS <-> SASS interop in some advanced cases. Without this, it wasn’t possible for my sprockets-directive-loader project to work when a SASS file
//= requireed a SCSS file. That’s because you would have had to setindentedSyntaxon the loader, and that would have been “passed-on” (viacss?importLoaders=*) to an SCSS file, causing its compile to fail.So with this change, this will now work for a mix of SCSS and SASS files: