Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a prefix to module tagging #586

Closed
doug-wade opened this issue Aug 18, 2016 · 0 comments
Closed

Add a prefix to module tagging #586

doug-wade opened this issue Aug 18, 2016 · 0 comments
Labels
enhancement New functionality.

Comments

@doug-wade
Copy link
Collaborator

From #583, to allow react-server-cli to remove the .src. from its tag, in addition to the "trim" option, we should allow a "prefix". So, given a file path of react-server-cli/src/logProductionWarnings.js, and options of { trim: 'react-server-cli.src', prefix: 'react-server-cli' }, you would get the tag react-server-cli.logProductionWarnings.
@doug-wade doug-wade added the enhancement New functionality. label Aug 18, 2016
doug-wade added a commit to doug-wade/react-server that referenced this issue Aug 23, 2016
@doug-wade
Fix redfin#586: Support prefixes in module tags
e846104
doug-wade added a commit to doug-wade/react-server that referenced this issue Aug 23, 2016
@doug-wade
Fix redfin#586: Support prefixes in gulp module tags
d208b38
doug-wade added a commit to doug-wade/react-server that referenced this issue Aug 23, 2016
@doug-wade
Fix redfin#586: Support prefixes in babel module tags
bb8720c
@doug-wade doug-wade mentioned this issue Aug 23, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@doug-wade