Cleaning up promise-from-getHeadStylesheets test page #115
Conversation
|
BTW, I noticed some weird behavior that I filed as #116. I didn't have time to dig into it though. |
| <div>If first.css shows up before second.css in the body of this page, all is well.</div>, | ||
| <div> | ||
| <h2>If the background is GREEN at page load, all is well!</h2> | ||
| <div>If it flashes red first, all is _not_ well.</div> |
There was a problem hiding this comment.
Isn't it actually the page winding up red that we're looking out for? In other words out of order CSS includes?
There was a problem hiding this comment.
It would be, but for #116. ClientCssHelper getting confused + the fact that it actually waits until all promises are resolved means that everything currently ends up correct at the end (after a 1s pause w/ a red background)
There was a problem hiding this comment.
Er. That is, everything works in this PR. You have to hand-modify renderMiddleware to the not-chained behavior in order to see the flash of red
😘 This is great! Plus you found a bug while you were working on it! |
Cleaning up getHeadStylesheets with promises test page.
@gigabo encouraged me to be cute, so I added a date endpoint for test pages that echoes CSS back.