-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code of conduct, badges, improve README #36
Conversation
needz moar badges -- maybe codeclimate? coveralls? powered by hipsters? |
@@ -6,3 +6,6 @@ Agreement](https://cla-assistant.io/redfin/react-server). The purpose | |||
of this license is to protect contributors, Redfin, as well as users | |||
of this software project. Signing this agreement does not affect your | |||
rights to use your contributions for any other purpose. | |||
|
|||
This project adheres to the [Open Code of Conduct][code-of-conduct]. By participating, you are expected to honor this code. | |||
[code-of-conduct]: http://todogroup.org/opencodeofconduct/#react-server/doug.wade@redfin.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the hash fragment at the end of this URL for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dunno, that's just what http://todogroup.org/opencodeofconduct/ spat out at me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe that email address should be to a group?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I guess we should get our dependencies up to date in packages before adding badges there. :) |
@@ -6,3 +6,6 @@ Agreement](https://cla-assistant.io/redfin/react-server). The purpose | |||
of this license is to protect contributors, Redfin, as well as users | |||
of this software project. Signing this agreement does not affect your | |||
rights to use your contributions for any other purpose. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should give other people, who are not watching this repository, a chance to weigh in on the code of conduct before we merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidalber lemme know when you've completed whatever offline review you feel is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Ship it! The Contributor Covenant one (c127c1e), that is.
@gigabo that means don't update the dependencies, yeah? |
f737b98
to
5a49d9c
Compare
Add code of conduct, badges, improve README
Address #29