Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code of conduct, badges, improve README #36

Merged
merged 3 commits into from
Mar 3, 2016

Conversation

doug-wade
Copy link
Collaborator

Address #29

@doug-wade
Copy link
Collaborator Author

needz moar badges -- maybe codeclimate? coveralls? powered by hipsters?

@@ -6,3 +6,6 @@ Agreement](https://cla-assistant.io/redfin/react-server). The purpose
of this license is to protect contributors, Redfin, as well as users
of this software project. Signing this agreement does not affect your
rights to use your contributions for any other purpose.

This project adheres to the [Open Code of Conduct][code-of-conduct]. By participating, you are expected to honor this code.
[code-of-conduct]: http://todogroup.org/opencodeofconduct/#react-server/doug.wade@redfin.com
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the hash fragment at the end of this URL for?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dunno, that's just what http://todogroup.org/opencodeofconduct/ spat out at me

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha:

image

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe that email address should be to a group?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gigabo
Copy link
Contributor

gigabo commented Feb 26, 2016

LGTM. I guess we should get our dependencies up to date in packages before adding badges there. :)

@@ -6,3 +6,6 @@ Agreement](https://cla-assistant.io/redfin/react-server). The purpose
of this license is to protect contributors, Redfin, as well as users
of this software project. Signing this agreement does not affect your
rights to use your contributions for any other purpose.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should give other people, who are not watching this repository, a chance to weigh in on the code of conduct before we merge.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidalber lemme know when you've completed whatever offline review you feel is necessary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Ship it! The Contributor Covenant one (c127c1e), that is.

@doug-wade
Copy link
Collaborator Author

@gigabo that means don't update the dependencies, yeah?

doug-wade added a commit that referenced this pull request Mar 3, 2016
Add code of conduct, badges, improve README
@doug-wade doug-wade merged commit b16a551 into redfin:master Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants