Hook for custom middleware #708
Conversation
| @@ -114,9 +114,22 @@ export default (webpackConfig) => { | |||
|
|
|||
| In the `.reactserverrc` file add an option for `webpack-config` that points to that function file and when React Server is setting up Webpack it will call your function with the result of the built in Webpack options, allowing you to make any modifications needed. | |||
|
|
|||
| ### Use Custom Express Middleware | |||
There was a problem hiding this comment.
@gigabo i am the worst at documentation so let me know what you think
There was a problem hiding this comment.
Express Middleware is order-dependent, which makes me think that custom middleware loading will need to be more intricate than this. In particular, it seems like users will want to have middleware run before compression, but after cookies and body are parsed, or to replace the cookie or body parsing middleware. I think a better approach would be to load no middleware other than react-server if custom middleware are specified, and provide the current behavior as a default to custom middleware stack.
|
Hi @doug-wade! It looks like @sresant has actually accounted for that. The default behavior remains to apply the various other middlewares (compression, etc) in a certain order and then apply the React Server middleware. But if the new hook is used the caller becomes responsible for applying all middleware, including compression, etc and React Server's, in whatever order is desired. |
| server.use(bodyParser.urlencoded({ extended: false })); | ||
| server.use(bodyParser.json()); | ||
| server.use(session(options)); | ||
| rsMiddleware(); // Must be called once or server will not start |
There was a problem hiding this comment.
This doesn't match the parameter name above (reactServerMiddleware there).
|
|
||
|
|
||
| In the `.reactserverrc` file add an option for `custom-middleware-path` that points to that function file and when React Server is setting up the server it will call your function for setup rather then the default middlewares mentioned above. On the command line the option is `--custom-middleware-path`. | ||
|
|
There was a problem hiding this comment.
I think we've generally used the camelCase variants in the config file? Like customMiddlewarePath?
Not sure if either will work, or even if I'm remembering right. ;)
There was a problem hiding this comment.
You are correct, i was just tired when writing up the documentation good catch!
Relates to #694.