Add cli option for webpack-config #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sresant
commented
Oct 11, 2016
| @@ -112,7 +112,7 @@ export default (webpackConfig) => { | |||
| } | |||
| ``` | |||
|
|
|||
| In the `.reactserverrc` file add an option for `webpack-config` that points to that function file and when React Server is setting up Webpack it will call your function with the result of the built in Webpack options, allowing you to make any modifications needed. | |||
| In the `.reactserverrc` file add an option for `webpackConfig` that points to that function file and when React Server is setting up Webpack it will call your function with the result of the built in Webpack options, allowing you to make any modifications needed. On the command line use the option `--webpack-config` | |||
There was a problem hiding this comment.
@gigabo i am the worst at documentation so let me know what you think.
There was a problem hiding this comment.
I might use wording that makes it clear that this is an alternative to the option in the config file. As it stands it's possible to misinterpret this to mean that even with the option in the config file you must also pass a CLI option to trigger its use.
Maybe something like:
This may also be specified on the command line with the
--webpack-config=<FILE>option.
gigabo
approved these changes
Nov 18, 2016
gigabo
added
enhancement
|
@sresant Please rebase this when you get a chance. |
sresant
force-pushed
the
st-add-cli-option-webpackconfig
branch
from
d22af2b
to
cd05c7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently do not have a command line option to pass a path to our webpack-config. This creates that option.