Add superagent to example package.json and print errors in cli.js #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Robert Law seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
emecell
force-pushed
the
superagent-example-fix
branch
2 times, most recently
from
e41b45b
to
3580210
Compare
sresant
reviewed
Nov 4, 2016
| @@ -12,6 +12,7 @@ const DEPENDENCIES = [ | |||
| // TODO: Modernize our peer deps and remove versions here. | |||
| "react@~0.14.2", | |||
| "react-dom@~0.14.2", | |||
| "superagent@~1.8.4", | |||
There was a problem hiding this comment.
@gigabo Opinion on the tilda here? or do we need to be strictly on 1.8.4?
There was a problem hiding this comment.
Yeah, probably safer to match up exactly with react-server.
emecell
force-pushed
the
superagent-example-fix
branch
from
3580210
to
1ef1cfe
Compare
|
Thanks @emecell! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #698