Handle Null and Promise.resolve(null) in renderMetaTags + renderLinkTags #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LinkTags(). Added a test harness for renderMiddleware to test this bug fix in the future.
gigabo
reviewed
Jan 6, 2017
| it("don't render meta tags", (finishTest) => { | ||
| _testFunctions.renderMetaTags(page, mockSocket) | ||
| .then(() => { | ||
| expect(mockSocket.toString()).toMatch(''); |
|
LGTM 👍 Thanks @drewpc! |
gigabo
approved these changes
Jan 6, 2017
|
I forgot to add a 'normal' values check! I'll do that now. |
|
lgtm |
# Conflicts: # packages/react-server/package.json
|
No changes since I submitted the PR. I saw that there were merge conflicts based on the latest dependency changes in the master branch and resolved the conflicts. |
|
Thanks for jumping on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed handling of
nullandPromise.resolve(null)forrenderMetaTagsandrenderLinkTags. Added a test harness forrenderMiddlewarewhich was used to recreate the problem and ensure successful resolution. Corresponds to issue #789