Test page for page forwarding #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orwarded pages Also ensure that bundle-splitting works for forwarded-to pages
doug-wade
reviewed
Jan 7, 2017
| //then depending on said data, forward to one of two pages, and pass along the data we pre-fetched | ||
| if (res.body % 2 === 0) { | ||
| if (typeof window !== 'undefined') { //would be nice if this is `process.env.isServer` | ||
| require.ensure(["./forwardEven"], () => { |
There was a problem hiding this comment.
I can't quite tell because babelification messes with line numbers, but it looks like the problem is that you're not returning the require.ensure result.
There was a problem hiding this comment.
Oh oops - thanks for the catch!
roblg
approved these changes
Jan 10, 2017
|
LGTM |
drewpc
requested changes
Jan 11, 2017
|
|
||
| return this.data.then((res) => { | ||
| //then depending on said data, forward to one of two pages, and pass along the data we pre-fetched | ||
| if (res.body % 2 === 0) { |
There was a problem hiding this comment.
Can you refactor this section a bit to limit code reuse? Something like this should work:
const pageName = (res.body % 2 === 0) ? "./forwardEven" : "./forwardOdd";
if (typeof window !== 'undefined') { //would be nice if this is `process.env.isServer`
return require.ensure([pageName], () => {
return {
page: require(pageName).default,
};
});
} else {
return {
page: require(pageName).default,
};
}
| return this.data.then((res) => { | ||
| //then depending on said data, forward to one of two pages, and pass along the data we pre-fetched | ||
| if (res.body % 2 === 0) { | ||
| if (typeof window !== 'undefined') { //would be nice if this is `process.env.isServer` |
There was a problem hiding this comment.
If you change this comment to be a // TODO:, we can track it better. Eventually when we get server side Webpack up and running, it'll include a fix for this.
Committing changes after review.
drewpc
approved these changes
Jan 15, 2017
|
Woops I went and neglected this PR, but looks like @drewpc got a handle on things, thank you very much for fixing + merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, to make sure that data can be passed down from the forwarding page to the forwarded-to page via the data cache, and that we can do code splitting between the forwarded-to pages. (Requirements for a particular use case I'm anticipating.)