Consolidate HTML + JS Servers #808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Replace dependency on webpack-dev-server with webpack-dev-middleware.
…emove dependency on webpack-dev-server
…single HTTP server.
Merged
# Conflicts: # packages/react-server-cli/package.json
jhnns
reviewed
Jan 10, 2017
| } | ||
|
|
||
| let middlewareSetup = (server, rsMiddleware) => { | ||
| server.use(compression()); |
There was a problem hiding this comment.
I don't know if that's a problem but it looks like the compression() middleware is used two times in non-hot mode.
There was a problem hiding this comment.
thanks! I fixed that.
11 tasks
# Conflicts: # packages/react-server-cli/src/commands/start.js # packages/react-server-cli/src/compileClient.js
…moved secondary use of `compression()` in non-hot mode (leftover from when this was used in a secondary Express instance).
# Conflicts: # packages/react-server-cli/src/commands/start.js
|
Closing this PR, pending further architecture discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #807 with the least controversial set of changes. See PR #791 for more discussion on this. Essentially, this PR does the following:
jsPort)hot === true,webpack-dev-serveris used as to create the HTTP/HTTPS server and Express application.react-serverpiggy backs off of the Express application by injecting itself into the middleware chain afterwebpack-dev-middlewareis injected. No proxying is required.hot === false,react-servercreates the HTTP/HTTPS server and Express application on its own and manually creates and runs a Webpack compiler for the client side code.In my opinion, this is not the cleanest path for
react-server, but it is the least controversial set of changes to the overall infrastructure while still reducing complexity at runtime.Another method of solving this problem is to stop using
webpack-dev-serverand attachwebpack-dev-middlewareto the Express application thatreact-servercreates. This will more easily allow people to use alternatives to Express in the future and keepreact-serveroperating the same in hot/not-hot modes. It does, however, move the client-side HMR mechanism away from something that the Webpack people maintain and over towebpack-hot-middleware. This project supports multiple compilers (which will be useful later), Webpack 2, and seems to be well maintained.Checkout this patch to see what this code would look like.
As always, feedback is appreciated.