Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated nsprcs #819

Merged
merged 1 commit into from
Jan 14, 2017
Merged

Remove outdated nsprcs #819

merged 1 commit into from
Jan 14, 2017

Conversation

doug-wade
Copy link
Collaborator

The fix made its way through the npm ecosystem

drewpc
drewpc reviewed Jan 11, 2017
View reviewed changes
Copy link
Collaborator

@drewpc drewpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this relate to #680?

@doug-wade
Copy link
Collaborator Author

Uh... I did a bad job titling #680 -- I named it after how I thought we'd fix the issue, rather than the actual issue. This closes #680, which I've updated to better describe the issue.

drewpc
drewpc approved these changes Jan 12, 2017
View reviewed changes
Copy link
Collaborator

@drewpc drewpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Further discussion is necessary on how to move forward in the future with this type of thing, but shouldn't hold up this PR.

@drewpc drewpc merged commit 267c963 into redfin:master Jan 14, 2017
@doug-wade doug-wade mentioned this pull request Jan 16, 2017
Closed
@drewpc drewpc modified the milestones: Production ready, 0.6.0 Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewpc drewpc drewpc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doug-wade @drewpc