Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update react-server dependencies on examples to latest #924

Merged
merged 1 commit into from
Apr 19, 2017
Merged

Update react-server dependencies on examples to latest #924

merged 1 commit into from
Apr 19, 2017

Conversation

nashio
Copy link
Contributor

@nashio nashio commented Apr 10, 2017

redux-basic example needs compatible version of react-server to install correctly.

npm ERR! notarget No compatible version found: react-server-redux@^0.5.1  
npm ERR! notarget Valid install targets:   
npm ERR! notarget 0.6.3, 0.6.1, 0.6.0

(other examples needed update also)

@CLAassistant
Copy link

CLAassistant commented Apr 10, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nashio nashio changed the title Update example react-server versions to latest Update react-server dependencies on examples to latest Apr 10, 2017
sresant
sresant approved these changes Apr 10, 2017
View reviewed changes
Copy link
Contributor

@sresant sresant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching this!

@nashio
Copy link
Contributor Author

nashio commented Apr 10, 2017

Hi, @sresant , do you know why this licence is pending?
licence/cla — Waiting for status to be reported

@sresant
Copy link
Contributor

sresant commented Apr 10, 2017

@nashio I have noticed a problem with the license/cla agreement taking some time to update itself, I also noticed an issue with it forgetting that a commiter had already signed the agreement...its flaky. No need to worry 👍

@gigabo
Copy link
Contributor

gigabo commented Apr 19, 2017

Thanks @nashio!

@gigabo gigabo merged commit 6faf79b into redfin:master Apr 19, 2017
@gigabo gigabo added the bug An issue with the system label Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sresant sresant sresant approved these changes

Assignees
No one assigned
Labels
bug An issue with the system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nashio @CLAassistant @sresant @gigabo