Simplify device type routing #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mobile-detect package is large. We shouldn't send it to the browser. This change uses mobile-detect on the server only. It associates a device type with the request and sends only that pre-determined value to the browser. This eliminates the "mobile" route target, which was previously the union of "phone" and "tablet". These two must be specified individually going forward (though they may route to the same page class). It also adds a "desktop" route target. The `getMobileDetect()` method on the request context is eliminated, and replaced with a `getDeviceType()` method that returns a string. This is a breaking change.
|
This addresses #883. |
roblg
reviewed
Sep 8, 2017
| if (!loader && loaders[format] && mobileDetect[format]()){ | ||
|
|
||
| // Need to disambiguate for bundleNameUtil. | ||
| route.name += '-'+format; |
There was a problem hiding this comment.
Do we not need this route.name override thing anymore for some reason?
There was a problem hiding this comment.
I guess maybe it's a product of eliminating mobile?
There was a problem hiding this comment.
Oh, nice catch. We use it for stat partitioning. I'll reintroduce that.
roblg
reviewed
Sep 8, 2017
| @@ -1070,6 +1071,17 @@ function getNonInternalConfigs() { | |||
| return nonInternal; | |||
| } | |||
|
|
|||
| function getDeviceType(req) { | |||
| var md = new MobileDetect(req.get('user-agent')); | |||
| var types = [ 'phone', 'tablet', 'mobile' ]; | |||
There was a problem hiding this comment.
This still includes mobile, but the PR comments say we're eliminating that. Can it be removed here?
There was a problem hiding this comment.
Thank goodness you're reviewing this carefully. 😳
roblg
approved these changes
Sep 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mobile-detect package is large. We shouldn't send it to the browser.
This change uses mobile-detect on the server only. It associates a device type with the request and sends only that pre-determined value to the browser.
This eliminates the "mobile" route target, which was previously the union of "phone" and "tablet". These two must be specified individually going forward (though they may route to the same page class). It also adds a "desktop" route target.
The
getMobileDetect()method on the request context is eliminated, and replaced with agetDeviceType()method that returns a string.This is a breaking change.