Try to require evil when compiling #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If evil is not loaded during compilation the evil-specific code will not work if evil is loaded later on as it seems the evil operator doesn't get defined.
redguardtoo
pushed a commit
that referenced
this pull request
Oct 30, 2014
Try to require evil when compiling
|
cool. thank you. a good solution. |
|
Actually, this doesn't help it seems. |
|
And of course the only reason it works is because requiring evil fails and so prevents byte-compilation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've had problems with the evil part of evil-nerd-commenter for a while, getting the message that
evilnc-comment-operatorwas undefined and I always worked around them by manually byte-compilingevil-nerd-commenter.el, sometimes twice. I've wanted to look into it for a while, but never got around to it.This change fixes the situation for me. Passing the
noerrorargument to require is meant to keep evil-nerd-commenter from making evil a hard requirement. This doesn't help if people install evil-nerd-commenter first and then later add evil.For a proper solution I would suggest looking into splitting the package in two, drastic as that may be. For example emacs-nerd-commenter and evil-nerd-commenter, where evil-nerd-commenter depends on both emacs-nerd-commenter and evil and emacs-nerd-commenter doesn't depend on anything.
This should help with #39 and possibly some others reporting the same problem.
Please let me know what you think, and if it helps.