Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add referral sources index #165

Merged
merged 1 commit into from May 24, 2017
Merged

Add referral sources index #165

merged 1 commit into from May 24, 2017

Conversation

JohnColvin
Copy link
Member

and related patient link

and related patient link
@jfriedlaender
Copy link
Member

Is this really what people want? Maybe someone that has requested it could give feedback? cc @hagen

@hagen
Copy link
Contributor

hagen commented May 24, 2017

At least two people... Referral sources can produce some useful metrics for a clinic when analysed in bulk. Acquiring them in bulk was the issue. Moreover, referral_sources now aligns with other endpoint signatures. Many thanks for the change.

@jfriedlaender
Copy link
Member

@hagen is this the format you were expecting and was most useful for you?

@hagen
Copy link
Contributor

hagen commented May 24, 2017

Ideally, each would have it's own id, updated_at, created_at, etc fields. Without these, querying them is not possible. But @JohnColvin did explain there were limitations to this. Understandable. The change means I can now acquire this data in bulk. Even if it does run a full query each time. You will no doubt get requests for filterable fields on this resource. But I'm happy with this change.

@JohnColvin
Copy link
Member Author

Serving referral sources as their own resource, even though the data currently sits on the patient table is a step in that direction. One day, we could switch the underlying data to its own table, and add id and the other fields, and enable filtering. It's not on my todo list for now, though.

@JohnColvin JohnColvin merged commit e6daf59 into master May 24, 2017
@JohnColvin JohnColvin deleted the referral-source-index branch May 24, 2017 14:11
@@ -56,6 +112,11 @@ There are a few possible types of referral sources. Depending on the type, diffe
"referrer_type": "Contact",
"subcategory": null,
"notes": "note written about this referral",
"patient": {
"links": {
"self": "http://local.cliniko.dev:3000/v1/patients/123"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those URLs are not pointing to the production environment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants