Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--layers option #42

Closed
tetchel opened this issue Mar 26, 2021 · 2 comments
Closed

--layers option #42

tetchel opened this issue Mar 26, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request
Projects

Comments

@tetchel
Copy link
Contributor

tetchel commented Mar 26, 2021

The --layers option is useful in buildah when given a persistent disk, but not useful in CI systems where the disk is discarded after each job

Since we've verified this option allows caching to work in the self-hosted buildah runner we should add an input for it

To keep with buildah behaviour, it should be false by default.

In addition, it may make sense to set export BUILDAH_LAYERS=true into the runner.

@tetchel tetchel added the enhancement New feature or request label Mar 26, 2021
@tetchel tetchel added this to To do in Sprint 199 Mar 26, 2021
@divyansh42 divyansh42 moved this from To do to In progress in Sprint 199 Mar 26, 2021
@tetchel
Copy link
Contributor Author

tetchel commented Mar 26, 2021

I am adding BUILDAH_LAYERS=true to the buildah runner dockerfile, but if --layers=false is passed to this action then the env var will get overridden.

So if layers is not set, do not pass --layers at all, to leave it up to the environment.

tetchel added a commit to redhat-actions/openshift-actions-runners that referenced this issue Mar 26, 2021
@divyansh42
Copy link
Member

Okay 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

2 participants