Skip to content

Commit

Permalink
Support/node20 (#93)
Browse files Browse the repository at this point in the history
* Update action.yml to use node20

* Update README.md with newer runner versions and fix typo

* Update all workflows to use newer action versions and runner environments
  • Loading branch information
Eusebiotrigo committed Mar 5, 2024
1 parent e85426e commit 0fa2dca
Show file tree
Hide file tree
Showing 11 changed files with 31 additions and 31 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/check-lowercase.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ env:
jobs:
push-ghcr:
name: Build and push image
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
strategy:
fail-fast: false
matrix:
Expand All @@ -26,7 +26,7 @@ jobs:
steps:
# Checkout push-to-registry action github repository
- name: Checkout Push to Registry action
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Install latest podman
if: matrix.install_latest
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,18 @@ jobs:
runs-on: ubuntu-20.04

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- run: npm ci
- run: npm run lint

check-dist:
name: Check Distribution
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
env:
BUNDLE_FILE: "dist/index.js"
BUNDLE_COMMAND: "npm run bundle"
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: Install
run: npm ci
Expand All @@ -33,11 +33,11 @@ jobs:

check-inputs-outputs:
name: Check Input and Output enums
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
env:
IO_FILE: ./src/generated/inputs-outputs.ts
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: Install dependencies
run: npm ci
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ghcr-push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ env:
jobs:
push-ghcr:
name: Build and push image
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
strategy:
fail-fast: false
matrix:
Expand All @@ -26,7 +26,7 @@ jobs:
steps:
# Checkout push-to-registry action github repository
- name: Checkout Push to Registry action
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Install latest podman
if: matrix.install_latest
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/link_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ on:
jobs:
markdown-link-check:
name: Check links in markdown
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- uses: gaurav-nelson/github-action-markdown-link-check@v1
with:
use-verbose-mode: true
6 changes: 3 additions & 3 deletions .github/workflows/manifest-build-push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ env:
jobs:
push-quay:
name: Build and push manifest
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
strategy:
fail-fast: false
matrix:
Expand All @@ -26,7 +26,7 @@ jobs:
steps:
# Checkout push-to-registry action github repository
- name: Checkout Push to Registry action
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Install latest podman
if: matrix.install_latest
Expand All @@ -51,7 +51,7 @@ jobs:
- name: Build Image
id: build_image
uses: redhat-actions/buildah-build@main
uses: redhat-actions/buildah-build@v2
with:
image: ${{ env.IMAGE_NAME }}
tags: ${{ env.IMAGE_TAGS }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/multiple-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
build:
name: |-
Build with ${{ matrix.build_with }} and push${{ matrix.fully_qualified_image_name_tag && ' FQIN' || '' }} (latest: ${{ matrix.install_latest }})
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
strategy:
fail-fast: false
matrix:
Expand All @@ -29,7 +29,7 @@ jobs:

# Checkout push-to-registry action github repository
- name: Checkout Push to Registry action
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Install latest podman
if: matrix.install_latest
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/quay-push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ env:
jobs:
push-quay:
name: Build and push image
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
strategy:
fail-fast: false
matrix:
Expand All @@ -26,7 +26,7 @@ jobs:
steps:
# Checkout push-to-registry action github repository
- name: Checkout Push to Registry action
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Install latest podman
if: matrix.install_latest
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/security_scan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,16 @@ on:

jobs:
crda-scan:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
name: Scan project vulnerability with CRDA
steps:

- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: Setup Node
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
node-version: '14'
node-version: '20'

- name: Install CRDA
uses: redhat-actions/openshift-tools-installer@v1
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/verify-login-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ env:
jobs:
login-and-push:
name: Login and push image to Quay.io
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
strategy:
fail-fast: false
matrix:
Expand All @@ -27,7 +27,7 @@ jobs:

# Checkout push-to-registry action github repository
- name: Checkout Push to Registry action
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Install latest podman
if: matrix.install_latest
Expand Down
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,10 @@ on: [ push ]
jobs:
build:
name: Build and push image
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: Build Image
id: build-image
Expand Down Expand Up @@ -144,13 +144,13 @@ If the image to push is present in both the Docker and Podman image storage, the
If the action pulled an image from the Docker image storage into the Podman storage, it will be cleaned up from the Podman storage before the action exits.

## Note about GitHub runners and Podman
We recommend using `runs-on: ubuntu-20.04` since it has a newer version of Podman.
We recommend using `runs-on: ubuntu-22.04` since it has a newer version of Podman.

If you are on `ubuntu-18.04` or any other older versions of ubuntu your workflow will use an older version of Podman and may encounter issues such as [#26](https://github.com/redhat-actions/push-to-registry/issues/26).
If you are on `ubuntu-20.04` or any other older versions of ubuntu your workflow will use an older version of Podman and may encounter issues such as [#26](https://github.com/redhat-actions/push-to-registry/issues/26).

## Troubleshooting
Note that quay.io repositories are private by default.<br>

This means that if you push an image for the first time, you will have to authenticate before pulling it, or go to the repository's settings and change its visibility.

Simiarly, if you receive a 403 Forbidden from GHCR, you may have to update the Package Settings. Refer to [this issue](https://github.com/redhat-actions/push-to-registry/issues/52).
Similarly, if you receive a 403 Forbidden from GHCR, you may have to update the Package Settings. Refer to [this issue](https://github.com/redhat-actions/push-to-registry/issues/52).
4 changes: 2 additions & 2 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ inputs:
tags:
description: |
'The tag or tags of the image/manifest to push.
For multiple tags, seperate by whitespace. For example, "latest v1"'
For multiple tags, separate by whitespace. For example, "latest v1"'
required: false
default: 'latest'
registry:
Expand Down Expand Up @@ -47,5 +47,5 @@ outputs:
registry-paths:
description: 'A JSON array of registry paths to which the tag(s) were pushed'
runs:
using: 'node16'
using: 'node20'
main: 'dist/index.js'

0 comments on commit 0fa2dca

Please sign in to comment.