Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read default build bundle from APIExport workspace #69

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

mmorhun
Copy link
Collaborator

@mmorhun mmorhun commented Oct 19, 2022

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?:

Changes default build bundle configuration way.
With this changes the following order is used:

  1. build-pipelines-defaults ConfigMap in the Component namespace
  2. build-pipelines-defaults ConfigMap in the build-templates namespace
  3. Fallback bundle (hardcoded)

Which issue(s)/story(ies) does this PR fixes:

https://issues.redhat.com/browse/PLNSRVCE-782

How to test changes / Special notes to the reviewer:

  1. Deploy AppStudio into KCP cluster
  2. Go to redhat-appstudio KCP-workspace, create build-templates namespace and create there ConfigMap named build-pipelines-defaults with default_build_bundle key and bundle as value.
  3. Go to appstudio KCP-workspace, create an Application and a Component.
  4. Check for a new build Pipeline and for the bundle used. It must be the bundle from the ConfigMap.

Depends on

redhat-appstudio/application-service#202

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Copy link
Contributor

@gabemontero gabemontero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero, Michkov, mmorhun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gabemontero,mmorhun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants