-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RELEASE-230): update release service ref to konflux ci org #1144
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
go.mod
Outdated
@@ -41,7 +41,7 @@ require ( | |||
github.com/redhat-appstudio/image-controller v0.0.0-20231003082540-48893226ba8b | |||
github.com/redhat-appstudio/integration-service v0.0.0-20231025084434-b3f521c408d1 | |||
github.com/redhat-appstudio/jvm-build-service v0.0.0-20240126122210-0e2ee7e2e5b0 | |||
github.com/redhat-appstudio/release-service v0.0.0-20240126184040-c1b86f4617e1 | |||
github.com/konflux-ci/release-service v0.0.0-20240126184040-c1b86f4617e1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect the version changes here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I am trying to find the correct version. Hope it will be available once we merge the release-service PR
Once available it will appear in this pkg search https://pkg.go.dev/search?q=konflux-ci&m=package
b23aa0c
to
f0a62a0
Compare
The dependency update requires the go version to be 1.21. @jinqi7 is taking a look.
|
I tried with go 1.21. But there are some conflicts between the new version of release-service and devfile library. It perhaps need to communicate with has team. github.com/devfile/library/v2/pkg/devfile/generator |
Thanks @jinqi7, FYI I shared the issue with HAS team and they are looking into this this: Slack Thread Meanwhile, adding @flacatus and @psturc they must have some experience with the situation and upgrading to |
@happybhati if go v1.21 is required, we also need to update the test runner image to a newer version here. I can take a look at it tomorrow |
Oh okay, Thanks a lot @psturc 👍🏻 |
@jinqi7 @happybhati upgrade to go v1.21 is in progress: |
e8d36f6
to
963f2a6
Compare
/retest |
@psturc, thanks for the changes. I am not sure why checks still failing :( |
@happybhati it's failing, because it still can't compile I guess some dependencies need to be updated to workaround the error? |
2ebda7d
to
2adacd4
Compare
This commit updates the `release-service` reference as result of migration to `konflux-ci` from `redhat-appstudio` GitHub org, more details parent EPIC: https://issues.redhat.com/browse/RHTAPREL-800 Signed-off-by: Happy Bhati <hbhati@redhat.com>
Quality Gate passedIssues Measures |
HAS team is working on the issue devfile/api#1543
Once this issue is resolved, we will be unblocked. |
🚨 Error occurred during the cluster's Bootstrapping phase, list of failed Spec(s):
@happybhati: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @happybhati I bumped the release-service version in this PR and pointed it to konflux-ci org Is it enough for closing this PR or some additional work should be done? |
Hey @psturc, I just verified, and we are good to close this PR as a result of #1220 |
This commit updates the
release-service
referenceas result of migration to
konflux-ci
fromredhat-appstudio
more details parent EPIC:
https://issues.redhat.com/browse/RHTAPREL-800
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Issue ticket number and link
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: